Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters (#25112) #25118

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 3, 2021

cherry-pick #25112 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25118

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25118:release-5.0-66e68be29658

What problem does this PR solve?

Issue Number: close #25100

Problem Summary: When a new cluster is deployed and it has never run GC, the tikv_gc_scan_lock_mode doesn't exist. In this case, select @@global.tidb_gc_scan_lock_mode will return the default value defined in sysvar.go. However, it's inconsistent with the actual default config, so it returns "PHYSICAL" while the actual mode is "LEGACY".

What is changed and how it works?

What's Changed: Changed the default value of sysvar global.tidb_gc_scan_lock_mode to "LEGACY".

Related changes

  • Need to cherry-pick to the release branch
    • release-5.0

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Deploy the cluster by tiup playground and run "select @@global.tidb_gc_scan_lock_mode" immediately, an it returns "LEGACY".

Side effects

  • None

Release note

  • Fix a bug that a new cluster's "tidb_gc_scan_lock_mode" global variable shows "PHYSICAL" instead of the actual default mode "LEGACY".

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/transaction SIG:Transaction size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 3, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 3, 2021
@ti-chi-bot ti-chi-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2021
@ti-srebot
Copy link
Contributor Author

@MyonKeminta you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2021
@MyonKeminta MyonKeminta force-pushed the release-5.0-66e68be29658 branch from cbbeeff to 1836f3d Compare June 4, 2021 05:05
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1836f3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@youjiali1995
Copy link
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/transaction SIG:Transaction size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants