-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters (#25112) #25118
sessionctx: Fix tidb_gc_scan_lock_mode sysvar doesn't show correct default value on new clusters (#25112) #25118
Conversation
/run-all-tests |
@MyonKeminta you're already a collaborator in bot's repo. |
cbbeeff
to
1836f3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/merge
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1836f3d
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
cherry-pick #25112 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25118
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #25100
Problem Summary: When a new cluster is deployed and it has never run GC, the
tikv_gc_scan_lock_mode
doesn't exist. In this case,select @@global.tidb_gc_scan_lock_mode
will return the default value defined in sysvar.go. However, it's inconsistent with the actual default config, so it returns "PHYSICAL" while the actual mode is "LEGACY".What is changed and how it works?
What's Changed: Changed the default value of sysvar
global.tidb_gc_scan_lock_mode
to "LEGACY".Related changes
Check List
Tests
Side effects
Release note