Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support get_format pushdown to tiflash #35950

Merged
merged 11 commits into from
Jul 14, 2022
Merged

expression: support get_format pushdown to tiflash #35950

merged 11 commits into from
Jul 14, 2022

Conversation

wirybeaver
Copy link
Contributor

@wirybeaver wirybeaver commented Jul 5, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #36035

Problem Summary:
Support get_format pushdown to TiFlash on TiDB side. Related TiFlash Issue: pingcap/tiflash#5115

What is changed and how it works?

function scalarExprSupportedByFlash return true when encountering the AST GetFormat node.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

support get_format pushdown to TiFlash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wshwsh12
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2022
@ti-chi-bot
Copy link
Member

Welcome @wirybeaver!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@wirybeaver wirybeaver mentioned this pull request Jul 5, 2022
Merged
12 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@wirybeaver
Copy link
Contributor Author

/run-all-test

@wirybeaver
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Jul 5, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ad0e1ef04e6d8664090e8ec67cb4cbb3c36a4d8b

@zanmato1984
Copy link
Contributor

Please add some UT. You can see this PR #35739 as a reference.

@wirybeaver wirybeaver marked this pull request as draft July 7, 2022 00:01
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2022
@wirybeaver wirybeaver changed the title support get_format pushdown to tiflash [WIP] support get_format pushdown to tiflash Jul 7, 2022
@wirybeaver wirybeaver changed the title [WIP] support get_format pushdown to tiflash expression: support get_format pushdown to tiflash Jul 8, 2022
@wirybeaver
Copy link
Contributor Author

/run-check_title

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2022
@wirybeaver
Copy link
Contributor Author 

[2022-07-08T19:01:26.601Z]   /home/jenkins/.tidb/tmp/b7c8fa3cc70b7c7023fdc4f79d50df0e/execroot/__main__/bazel-out/k8-fastbuild/testlogs/tests/realtikvtest/sessiontest/sessiontest_test/shard_4_of_50/coverage.dat
[2022-07-08T19:01:26.601Z] //statistics/handle:handle_test                                           FLAKY, failed in 1 out of 51 in 9.4s

Flaky unit test caused by TiKV.

@wirybeaver wirybeaver marked this pull request as ready for review July 8, 2022 19:57
@wirybeaver
Copy link
Contributor Author

Release note only need to write as support get_format pushdown to TiFlash.

Done

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022
@wirybeaver wirybeaver requested a review from zanmato1984 July 13, 2022 16:01
zanmato1984
zanmato1984 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zanmato1984: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@SeaRise: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@mengxin9014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2022
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2146c8d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@zanmato1984
Copy link
Contributor

/run-unit-test

@zanmato1984
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 74102dd into pingcap:master Jul 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 14, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 35, total 36 30 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 8 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 9 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 2 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 47 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GetFormat function push down to TiFlash
7 participants
@wirybeaver @ti-chi-bot @sre-bot @zanmato1984 @SeaRise @wshwsh12 @mengxin9014