Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: support get_format pushdown to tiflash #35950

Merged
merged 11 commits into from
Jul 14, 2022
Merged

expression: support get_format pushdown to tiflash #35950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39cbca7
support get_format pushdown to tiflash
wirybeaver Jul 5, 2022
16d57bd
Merge branch 'master' into xuanyili/getFormat
wirybeaver Jul 5, 2022
50460c4
add unit test; integeration test is on the way
wirybeaver Jul 8, 2022
19dba5e
Merge remote-tracking branch 'origin/xuanyili/getFormat' into xuanyil…
wirybeaver Jul 8, 2022
5c29005
add integration test
wirybeaver Jul 8, 2022
d9990d4
Merge branch 'master' into xuanyili/getFormat
wirybeaver Jul 8, 2022
6980e9d
Update planner/core/integration_test.go
wirybeaver Jul 11, 2022
d7c3951
return true directly for getformat pushdown check own to non overloading
wirybeaver Jul 13, 2022
2146c8d
Merge remote-tracking branch 'upstream-fork/master' into xuanyili/get…
wirybeaver Jul 13, 2022
765d99e
Merge branch 'master' into xuanyili/getFormat
ti-chi-bot Jul 14, 2022
ad0e1ef
Merge branch 'master' into xuanyili/getFormat
ti-chi-bot Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions expression/expr_to_pb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,10 @@ func TestExprOnlyPushDownToFlash(t *testing.T) {
require.NoError(t, err)
exprs = append(exprs, function)

function, err = NewFunction(mock.NewContext(), ast.GetFormat, types.NewFieldType(mysql.TypeString), stringColumn, stringColumn)
require.NoError(t, err)
exprs = append(exprs, function)

function, err = NewFunction(mock.NewContext(), ast.TimestampDiff, types.NewFieldType(mysql.TypeLonglong), stringColumn, datetimeColumn, datetimeColumn)
require.NoError(t, err)
exprs = append(exprs, function)
Expand Down
2 changes: 2 additions & 0 deletions expression/expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,6 +1158,8 @@ func scalarExprSupportedByFlash(function *ScalarFunction) bool {
}
case ast.IsTruthWithNull, ast.IsTruthWithoutNull, ast.IsFalsity:
return true
case ast.GetFormat:
return true
}
return false
}
Expand Down
23 changes: 23 additions & 0 deletions planner/core/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7017,3 +7017,26 @@ func TestIssue36194(t *testing.T) {
" └─Selection 100.00 mpp[tiflash] gt(plus(test.t.a, 1), 20)",
" └─TableFullScan 125.00 mpp[tiflash] table:t keep order:false, stats:pseudo"))
}

func TestGetFormatPushDownToTiFlash(t *testing.T) {
store, dom, clean := testkit.CreateMockStoreAndDomain(t)
defer clean()
tk := testkit.NewTestKit(t, store)

tk.MustExec("use test")
tk.MustExec("create table t(location varchar(10));")
tk.MustExec("insert into t values('USA'), ('JIS'), ('ISO'), ('EUR'), ('INTERNAL')")
tk.MustExec("set @@tidb_enforce_mpp=1;")
tk.MustExec("set @@tidb_isolation_read_engines = 'tiflash';")

tbl, err := dom.InfoSchema().TableByName(model.CIStr{O: "test", L: "test"}, model.CIStr{O: "t", L: "t"})
require.NoError(t, err)
// Set the hacked TiFlash replica for explain tests.
tbl.Meta().TiFlashReplica = &model.TiFlashReplicaInfo{Count: 1, Available: true}

tk.MustQuery("explain format = 'brief' select GET_FORMAT(DATE, location) from t;").Check(testkit.Rows(
"TableReader 10000.00 root data:ExchangeSender",
"└─ExchangeSender 10000.00 mpp[tiflash] ExchangeType: PassThrough",
" └─Projection 10000.00 mpp[tiflash] get_format(DATE, test.t.location)->Column#3",
" └─TableFullScan 10000.00 mpp[tiflash] table:t keep order:false, stats:pseudo"))
}