Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace exp/slices with std #45978

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 10, 2023

What problem does this PR solve?

Issue Number: ref #45933

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from a team as a code owner August 10, 2023 14:28
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #45978 (f95d3c1) into master (d819ea3) will decrease coverage by 1.5247%.
Report is 3 commits behind head on master.
The diff coverage is 90.4761%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45978        +/-   ##
================================================
- Coverage   74.7849%   73.2602%   -1.5247%     
================================================
  Files          1293       1300         +7     
  Lines        397964     400546      +2582     
================================================
- Hits         297617     293441      -4176     
- Misses        80985      88537      +7552     
+ Partials      19362      18568       -794     
Flag Coverage Δ
integration 26.3929% <23.8095%> (-20.1731%) ⬇️
unit 73.4729% <90.4761%> (+0.1370%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0419% <ø> (-0.0076%) ⬇️
br 51.1745% <ø> (-13.5925%) ⬇️

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 10, 2023
@hawkingrei hawkingrei requested a review from dveeden August 10, 2023 15:40
@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 10, 2023
Copy link

@easonn7 easonn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

There are no variable or config changes, LGTM from PM perspective.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

@easonn7: Please do not delete or edit you lgtm type comment!

In response to this:

/LGTM

There is no variable or config changes, LGTM from PM perspective.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

@easonn7: Please do not delete or edit you lgtm type comment!

In response to this:

/LGTM

There are no variable or config changes, LGTM from PM perspective.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei hawkingrei requested a review from lance6716 August 11, 2023 02:12
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-11 01:12:48.022098471 +0000 UTC m=+247932.571114458: ☑️ agreed by easonn7.
  • 2023-08-11 02:14:27.128782695 +0000 UTC m=+251631.677798682: ☑️ agreed by lance6716.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0eac1db into pingcap:master Aug 11, 2023
@hawkingrei hawkingrei removed the request for review from a team August 11, 2023 03:53
@hawkingrei hawkingrei deleted the exp_slices branch August 11, 2023 03:55
@D3Hunter D3Hunter mentioned this pull request Jun 4, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants