Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade x/exp/slices version #53785

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jun 4, 2024

What problem does this PR solve?

Issue Number: ref #45976

Problem Summary:

What changed and how does it work?

in tiflow repo, we want to pick pingcap/tiflow#11188, but it upgrades x/exp which is in-compatible with tidb/parser. in tidb repo, there are multiple PRs that tries to replace x/exp/ with golang std on master branch, such as #45978 #46433 #45996 #46292 #46339, but for golang 1.19 in 6.5 branch, we cannot directly cherry-pick them, as golang 1.19 doesn't have slices pkg, so we manually pick them and replace some methods with our implementation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 4, 2024
Copy link

tiprow bot commented Jun 4, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2024
Copy link

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-04 05:48:04.151450232 +0000 UTC m=+3360237.908585805: ☑️ agreed by hawkingrei.
  • 2024-06-04 05:49:05.066966156 +0000 UTC m=+3360298.824101730: ☑️ agreed by lance6716.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jun 4, 2024

/retest

Copy link

tiprow bot commented Jun 4, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 77.17391% with 63 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@18fcc2f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #53785   +/-   ##
================================================
  Coverage               ?   73.6449%           
================================================
  Files                  ?       1097           
  Lines                  ?     351735           
  Branches               ?          0           
================================================
  Hits                   ?     259035           
  Misses                 ?      76051           
  Partials               ?      16649           

@ti-chi-bot ti-chi-bot bot merged commit 607c846 into pingcap:release-6.5 Jun 4, 2024
13 checks passed
@D3Hunter D3Hunter deleted the upgrade-exp branch June 4, 2024 07:31
@D3Hunter D3Hunter mentioned this pull request Oct 31, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants