ddl: Exchange partition rollback (#45877) #45980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
ti-chi-bot
added
ok-to-test
ti-chi-bot
added
the
cherry-pick-approved
mjonss
approved these changes
Aug 17, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
ti-chi-bot
removed
the
cherry-pick-approved
|
/retest |
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
removed
the
cherry-pick-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjonss, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
ti-chi-bot
added
the
cherry-pick-approved
YangKeao
force-pushed
the
cherry-pick-45877-to-release-6.5
branch
from
4a6c2dd to
4776f61
Compare
|
/retest |
…5877-to-release-6.5
|
/retest |
|
/run-mysql-test |
|
/retest |
YangKeao
force-pushed
the
cherry-pick-45877-to-release-6.5
branch
2 times, most recently
from
196a085 to
937ccd5
Compare
YangKeao
force-pushed
the
cherry-pick-45877-to-release-6.5
branch
from
937ccd5 to
9251dd2
Compare
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
cherry-pick-45877-to-release-6.5
branch
from
9251dd2 to
dde2649
Compare
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45980 +/- ##
================================================
Coverage ? 73.6591%
================================================
Files ? 1084
Lines ? 348322
Branches ? 0
================================================
Hits ? 256571
Misses ? 75264
Partials ? 16487 |
YangKeao
pushed a commit
to YangKeao/tidb
that referenced
this pull request
Sep 12, 2023
close pingcap#45791, close pingcap#45920 Signed-off-by: Yang Keao <[email protected]>
12 tasks
5 tasks
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45877
What problem does this PR solve?
Issue Number: close #45791, close #45920
Problem Summary:
The first schema change state adds a restriction to the non-partitioned table, so that it can only write (insert/update) rows that would fit into the partition to be exchanged with. But if something fails afterwards, this is never cleared.
What is changed and how it works?
Adding rollback, in case of user cancellation or failure during the DDL execution, after the first state change.
Check List
Tests
Manual test for upgrade scenario, revert the changes made to
ddl/ddl_worker.go(which sets thediffstruct) and run the tests manually.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.