Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, sysvar: remove Switch EnableMDL logs #47227

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #47224

Problem Summary:

Remove the redundant logs.

What is changed and how it works?

These logs are added for debugging UTs and understanding the logic of "Enable MDL". They are quite meaningless, so should be removed from the released codes. I forgot to remove them in #45980.

It only affects 6.5.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 25, 2023
@YangKeao YangKeao requested a review from a team as a code owner September 25, 2023 03:23
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2023
@YangKeao YangKeao requested review from mjonss and tangenta September 25, 2023 03:24
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 25, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-25 03:25:47.376572081 +0000 UTC m=+245337.094914297: ☑️ agreed by tangenta.
  • 2023-09-25 03:39:28.936615972 +0000 UTC m=+246158.654958189: ☑️ agreed by bb7133.

Signed-off-by: Yang Keao <[email protected]>
@YangKeao
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@484d8d6). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #47227   +/-   ##
================================================
  Coverage               ?   73.7091%           
================================================
  Files                  ?       1085           
  Lines                  ?     348403           
  Branches               ?          0           
================================================
  Hits                   ?     256805           
  Misses                 ?      75137           
  Partials               ?      16461           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2e06333 into pingcap:release-6.5 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants