-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: pause scheduler after all connections established #51823
operator: pause scheduler after all connections established #51823
Conversation
Signed-off-by: Yu Juncen <[email protected]>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51823 +/- ##
=================================================
- Coverage 72.4345% 55.6554% -16.7791%
=================================================
Files 1476 1587 +111
Lines 364442 621175 +256733
=================================================
+ Hits 263982 345718 +81736
- Misses 80976 251964 +170988
- Partials 19484 23493 +4009
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
release-6.5 cherrypick was closed without merging. #52068. |
Oh. Seems like it was pulled into release6.5 via #51730 |
What problem does this PR solve?
Issue Number: ref #51448
Problem Summary:
In #51449, we delayed pausing admin commands after all connections are established. But that isn't enough, due to PD schedulers are paused and ID allocation is disabled.
What changed and how does it work?
This PR pauses PD's scheduler after all connections are established.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.