-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: allow StatePublic
in createTableWithForeignKeys
for BR
#51870
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51870 +/- ##
=================================================
- Coverage 70.7104% 56.2635% -14.4470%
=================================================
Files 1477 1592 +115
Lines 438429 618687 +180258
=================================================
+ Hits 310015 348095 +38080
- Misses 108992 246941 +137949
- Partials 19422 23651 +4229
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test pull-br-integration-test |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-br-integration-test |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-br-integration-test |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-br-integration-test |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yang Keao <[email protected]>
/test pull-br-integration-test |
@YangKeao: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
2 similar comments
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51838
Problem Summary:
When restoring some tables, the state can be
StatePublic
, socreateTableWithForeignKeys
should also handle theStatePublic
.What changed and how does it work?
Also handle the
StatePublic
increateTableWithForeignKeys
. IncreateTable
, theState
will always be reset toStateNone
(though sounds weird 🤦, but this code has been existing for 8 years).Check List
Tests
Side effects
Documentation
Release note