-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: allow StatePublic
in createTableWithForeignKeys
for BR (#51870)
#52021
ddl: allow StatePublic
in createTableWithForeignKeys
for BR (#51870)
#52021
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
/test pull-br-integration-test |
@YangKeao: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #52021 +/- ##
================================================
Coverage ? 73.6435%
================================================
Files ? 1095
Lines ? 350905
Branches ? 0
================================================
Hits ? 258419
Misses ? 75884
Partials ? 16602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #51870
What problem does this PR solve?
Issue Number: close #51838
Problem Summary:
When restoring some tables, the state can be
StatePublic
, socreateTableWithForeignKeys
should also handle theStatePublic
.What changed and how does it work?
Also handle the
StatePublic
increateTableWithForeignKeys
. IncreateTable
, theState
will always be reset toStateNone
(though sounds weird 🤦, but this code has been existing for 8 years).Check List
Tests
Side effects
Documentation
Release note