expression: fix the collation of functions with json arguments (#53126) #53200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #53126
What problem does this PR solve?
Issue Number: close #52833
Problem Summary:
MySQL will use binary collation when the
max_length
of some arguments' types are too long. It'll mostly happen onJSON
types.What changed and how does it work?
As TiDB doesn't have a
max_length
attribute for each type and "datum", I specially handled the situation for JSON. Some function will return binary collation when some of the arguments are JSON type.In MySQL, the state of
BINARY
flag,BLOB
type andbinary
collation is really a chaos. For this example, you'll find that sometimes thecollation(...)
returnsutf8mb4_bin
while the returned type info (shown through--column-type-info
) tells you the collation isutf8mb4_0900_ai_ci
. I'm not sure whether it's a bug for MySQL or not...So, I want to fix the behavior with minimum modification: only change the collation to binary collation and don't touch the charset.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.