-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix the collation of functions with json arguments #53126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53126 +/- ##
================================================
+ Coverage 74.4098% 74.5693% +0.1595%
================================================
Files 1490 1492 +2
Lines 356051 436989 +80938
================================================
+ Hits 264937 325860 +60923
- Misses 71835 91088 +19253
- Partials 19279 20041 +762
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dc1e98e
to
cdce63c
Compare
/retest |
1 similar comment
/retest |
Signed-off-by: Yang Keao <[email protected]>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/retest |
1 similar comment
/retest |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #52833
Problem Summary:
MySQL will use binary collation when the
max_length
of some arguments' types are too long. It'll mostly happen onJSON
types.What changed and how does it work?
As TiDB doesn't have a
max_length
attribute for each type and "datum", I specially handled the situation for JSON. Some function will return binary collation when some of the arguments are JSON type.In MySQL, the state of
BINARY
flag,BLOB
type andbinary
collation is really a chaos. For this example, you'll find that sometimes thecollation(...)
returnsutf8mb4_bin
while the returned type info (shown through--column-type-info
) tells you the collation isutf8mb4_0900_ai_ci
. I'm not sure whether it's a bug for MySQL or not...So, I want to fix the behavior with minimum modification: only change the collation to binary collation and don't touch the charset.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.