-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix the collation of functions with json arguments (#53126) #53203
expression: fix the collation of functions with json arguments (#53126) #53203
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53203 +/- ##
================================================
Coverage ? 71.9982%
================================================
Files ? 1411
Lines ? 410074
Branches ? 0
================================================
Hits ? 295246
Misses ? 94961
Partials ? 19867
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Close, because it will break compatibility. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #53126
What problem does this PR solve?
Issue Number: close #52833
Problem Summary:
MySQL will use binary collation when the
max_length
of some arguments' types are too long. It'll mostly happen onJSON
types.What changed and how does it work?
As TiDB doesn't have a
max_length
attribute for each type and "datum", I specially handled the situation for JSON. Some function will return binary collation when some of the arguments are JSON type.In MySQL, the state of
BINARY
flag,BLOB
type andbinary
collation is really a chaos. For this example, you'll find that sometimes thecollation(...)
returnsutf8mb4_bin
while the returned type info (shown through--column-type-info
) tells you the collation isutf8mb4_0900_ai_ci
. I'm not sure whether it's a bug for MySQL or not...So, I want to fix the behavior with minimum modification: only change the collation to binary collation and don't touch the charset.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.