-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json, expression: implicitly convert JSON string to time types #53363
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I remembered another issue: #50370. I need to check whether this PR will bring some potential correctness issue later 🤔 . |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53363 +/- ##
================================================
+ Coverage 72.4996% 74.5644% +2.0647%
================================================
Files 1505 1505
Lines 429646 430456 +810
================================================
+ Hits 311492 320967 +9475
+ Misses 98849 89563 -9286
- Partials 19305 19926 +621
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
Signed-off-by: Yang Keao <[email protected]>
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #53243, close #53352
Problem Summary:
Two problem:
DATE/DATETIME/TIMESTAMP array
.fsp
when converting JSON toDATE/DATETIME/TIMESTAMP
.What changed and how does it work?
DATE/DATETIME/TIMESTAMP
when we are converting them toDATE/DATETIME/TIMESTAMP
array.GetTime
which uses theDefaultFsp
, and implement a new method onBinaryJSON
to returntypes.Time
with the providedFsp
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.