-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix the fsp of casting json as datetime/duration #53535
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53535 +/- ##
================================================
+ Coverage 72.5278% 74.7153% +2.1874%
================================================
Files 1505 1505
Lines 429901 432112 +2211
================================================
+ Hits 311798 322854 +11056
+ Misses 98809 89340 -9469
- Partials 19294 19918 +624
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <[email protected]>
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #53352
Problem Summary:
When casting json as datetime/duration, the
fsp
of target type is not obeyed.This PR is split from #53363, because #53363 will be held for a while (as long as MySQL didn't confirm the behavior on JSON implicit cast). This one is a pure/simple bug fix, so it can be merged at first.
What changed and how does it work?
Follow the configuration of the return type to set the correct
fsp
. This PR didn't remove the originalGetTime
function, but just mark it as deprecated, because there are still many usages inside thejson
itself.Check List
Tests
Side effects
Documentation
Release note