planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic #53794

AilinKid · 2024-06-04T07:20:20Z

What problem does this PR solve?

Issue Number: close #53713

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
use the valid SQL and error SQL inside issue to produce result
and compare it with MySQL output, both them output like below:

mysql> source /Users/arenatlx/Downloads/error.txt
+------+------+------+------+
| c1   | c3   | c4   | c5   |
+------+------+------+------+
| NULL | NULL | 4    | NULL |
+------+------+------+------+
1 row in set (0.04 sec)

No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed an issue where the column evaluator could not detect column references in the input chunk. This bug caused the column evaluator to potentially lose the original input column data during projection, disrupting subsequent reference projection logic.
修复了 column evaluator 无法识别输入 chunk 中的列引用的问题。该问题会导致在投影过程中，column evaluator 可能丢失原始输入列的内容，从而破坏后续引用投影逻辑。

tiprow · 2024-06-04T07:20:36Z

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

winoros · 2024-06-04T07:36:32Z

pkg/expression/evaluator.go

+	for inputIdx, outputIdxes := range inputIdxToOutputIdxes {
+		find = false
+		root = inputIdx
+		for k, v := range selfRef {
+			for _, one := range v {
+				// if current inputIdx is in the value set of one selfRef. output the Root.
+				if inputIdx == one {
+					find = true
+					root = k
+					break
+				}
+			}
+			if find {
+				break
+			}
+		}
+		// if we found, root should be redirected to real root of inputIdx (link the real root)
+		// if we didn't, root should be the original inputIdx as it was. (inputIdx itself is a root)
+		if _, ok := rootIdxToOutputIdxes[root]; ok {
+			rootIdxToOutputIdxes[root] = append(rootIdxToOutputIdxes[root], outputIdxes...)
+		} else {
+			// if not find in any value set, it means input idx itself is a root.
+			rootIdxToOutputIdxes[root] = append(rootIdxToOutputIdxes[root], outputIdxes...)
+		}
+	}


I think we're doing things like the disjoint set? There's already a implemented disjoint set in util

codecov · 2024-06-04T07:41:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8522%. Comparing base (a187e9d) to head (bd0803b).
Report is 781 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53794        +/-   ##
================================================
+ Coverage   72.8506%   74.8522%   +2.0016%     
================================================
  Files          1562       1568         +6     
  Lines        439181     442974      +3793     
================================================
+ Hits         319946     331576     +11630     
+ Misses        99531      91060      -8471     
- Partials      19704      20338       +634

Flag	Coverage Δ
integration	`49.4644% <100.0000%> (?)`
unit	`71.7530% <100.0000%> (-0.0935%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9567% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`52.5288% <ø> (+6.6287%)`	⬆️

ti-chi-bot · 2024-07-24T05:33:53Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AilinKid · 2024-07-29T08:30:28Z

/retest-required

tiprow · 2024-07-29T08:30:50Z

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid · 2024-07-29T09:10:19Z

/retest-required

tiprow · 2024-07-29T09:10:42Z

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid · 2024-07-29T09:11:00Z

/ok-to-test

pkg/expression/evaluator.go

pkg/util/disjointset/set.go

AilinKid · 2024-07-30T08:00:35Z

/retest-required

AilinKid · 2024-07-30T08:01:02Z

/test fast_test_tiprow

ti-chi-bot · 2024-07-30T08:01:05Z

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/expression/evaluator.go

XuHuaiyu · 2024-07-30T08:05:31Z

release note provided by gpt:

Release Note - Chinese Version

修复：

修复了 column evaluator 无法识别输入 chunk 中的列引用的问题。该问题会导致在投影过程中，column evaluator 可能丢失原始输入列的内容，从而破坏后续引用投影逻辑。

Release Note - English Version

Fix:

Fixed an issue where the column evaluator could not detect column references in the input chunk. This bug caused the column evaluator to potentially lose the original input column data during projection, disrupting subsequent reference projection logic.

ti-chi-bot · 2024-08-01T04:08:46Z

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: AilinKid <[email protected]>

AilinKid · 2024-08-01T07:28:23Z

tidb> source /Users/arenatlx/Downloads/error.txt
+------+------+----+------+
| c1   | c3   | c4 | c5   |
+------+------+----+------+
| NULL | NULL | 4  | NULL |
+------+------+----+------+
1 row in set (0.01 sec)

should be ok

Signed-off-by: AilinKid <[email protected]>

AilinKid · 2024-08-01T08:01:04Z

/retest-required

AilinKid · 2024-08-01T08:32:09Z

/retest-required

AilinKid · 2024-08-01T09:08:32Z

/test check-dev2

tiprow · 2024-08-01T09:08:54Z

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AilinKid · 2024-08-01T09:58:02Z

/retest-required

AilinKid · 2024-08-01T10:19:53Z

/retest-required

AilinKid · 2024-08-01T12:19:57Z

/retest-required

ti-chi-bot · 2024-08-01T13:33:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [XuHuaiyu,winoros]
~~pkg/expression/OWNERS~~ [XuHuaiyu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-08-01T13:33:54Z

[LGTM Timeline notifier]

Timeline:

2024-07-30 10:16:22.202515182 +0000 UTC m=+264498.482563250: ☑️ agreed by XuHuaiyu.
2024-08-01 13:33:53.353108829 +0000 UTC m=+10030.571870438: ☑️ agreed by winoros.

winoros · 2024-08-01T13:34:59Z

/retest

Signed-off-by: AilinKid <[email protected]>

ti-chi-bot · 2024-09-20T15:10:54Z

In response to a cherrypick label: new pull request created to branch release-7.5: #56199.

Signed-off-by: ti-chi-bot <[email protected]>

…hus swapping and destroying later column ref projection logic (#53794) (#56199) close #53713

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-11-14T06:49:46Z

In response to a cherrypick label: new pull request created to branch release-8.1: #57380.

…hus swapping and destroying later column ref projection logic (#53794) (#57380) close #53713

ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Jun 4, 2024

AilinKid changed the title ~~fix column evaluator can not detect input's column-ref and thus swapping and destorying later ref projection logic~~ fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic Jun 4, 2024

winoros reviewed Jun 4, 2024

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024

AilinKid changed the title ~~fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic~~ planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic Jul 25, 2024

ti-chi-bot bot removed the do-not-merge/invalid-title label Jul 25, 2024

AilinKid force-pushed the fix-column-eval branch from baedc3e to 70d98ca Compare July 29, 2024 07:44

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 29, 2024

XuHuaiyu reviewed Jul 29, 2024

View reviewed changes

pkg/expression/evaluator.go Outdated Show resolved Hide resolved

pkg/expression/evaluator.go Outdated Show resolved Hide resolved

winoros reviewed Jul 29, 2024

View reviewed changes

pkg/util/disjointset/set.go Outdated Show resolved Hide resolved

pkg/util/disjointset/set.go Outdated Show resolved Hide resolved

AilinKid force-pushed the fix-column-eval branch from 39efd88 to 045545a Compare July 30, 2024 06:39

XuHuaiyu reviewed Jul 30, 2024

View reviewed changes

pkg/expression/evaluator.go Outdated Show resolved Hide resolved

AilinKid force-pushed the fix-column-eval branch from 0ef0440 to d73466e Compare July 30, 2024 09:35

XuHuaiyu approved these changes Jul 30, 2024

View reviewed changes

.

9888a21

Signed-off-by: AilinKid <[email protected]>

.

57457f7

Signed-off-by: AilinKid <[email protected]>

winoros approved these changes Aug 1, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2024

AilinKid added 2 commits August 2, 2024 13:02

“。”

be5a630

Signed-off-by: AilinKid <[email protected]>

.

bd0803b

Signed-off-by: AilinKid <[email protected]>

ti-chi-bot bot merged commit 801d5d6 into pingcap:master Aug 2, 2024
12 checks passed

ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 20, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 20, 2024

This is an automated cherry-pick of pingcap#53794

da2676e

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Sep 20, 2024

planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic (#53794) #56199

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Sep 26, 2024

planner: fix column evaluator can not detect input's column-ref and t…

8e57797

…hus swapping and destroying later column ref projection logic (#53794) (#56199) close #53713

AilinKid added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Nov 14, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 14, 2024

This is an automated cherry-pick of pingcap#53794

e1a7327

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Nov 14, 2024

planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic (#53794) #57380

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 15, 2024

planner: fix column evaluator can not detect input's column-ref and t…

af934cf

…hus swapping and destroying later column ref projection logic (#53794) (#57380) close #53713

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic #53794

planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic #53794

AilinKid commented Jun 4, 2024 •

edited

Loading

tiprow bot commented Jun 4, 2024

winoros Jun 4, 2024

AilinKid Jun 4, 2024

codecov bot commented Jun 4, 2024 •

edited

Loading

ti-chi-bot bot commented Jul 24, 2024

AilinKid commented Jul 29, 2024

tiprow bot commented Jul 29, 2024

AilinKid commented Jul 29, 2024

tiprow bot commented Jul 29, 2024

AilinKid commented Jul 29, 2024

AilinKid commented Jul 30, 2024

AilinKid commented Jul 30, 2024

ti-chi-bot bot commented Jul 30, 2024

XuHuaiyu commented Jul 30, 2024 •

edited

Loading

ti-chi-bot bot commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

tiprow bot commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

ti-chi-bot bot commented Aug 1, 2024

ti-chi-bot bot commented Aug 1, 2024

winoros commented Aug 1, 2024

ti-chi-bot commented Sep 20, 2024

ti-chi-bot commented Nov 14, 2024

planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic #53794

planner: fix column evaluator can not detect input's column-ref and thus swapping and destroying later column ref projection logic #53794

Conversation

AilinKid commented Jun 4, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Jun 4, 2024

winoros Jun 4, 2024

Choose a reason for hiding this comment

AilinKid Jun 4, 2024

Choose a reason for hiding this comment

codecov bot commented Jun 4, 2024 • edited Loading

Codecov Report

ti-chi-bot bot commented Jul 24, 2024

AilinKid commented Jul 29, 2024

tiprow bot commented Jul 29, 2024

AilinKid commented Jul 29, 2024

tiprow bot commented Jul 29, 2024

AilinKid commented Jul 29, 2024

AilinKid commented Jul 30, 2024

AilinKid commented Jul 30, 2024

ti-chi-bot bot commented Jul 30, 2024

XuHuaiyu commented Jul 30, 2024 • edited Loading

Release Note - Chinese Version

Release Note - English Version

ti-chi-bot bot commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

tiprow bot commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

AilinKid commented Aug 1, 2024

ti-chi-bot bot commented Aug 1, 2024

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

winoros commented Aug 1, 2024

ti-chi-bot commented Sep 20, 2024

ti-chi-bot commented Nov 14, 2024

AilinKid commented Jun 4, 2024 •

edited

Loading

codecov bot commented Jun 4, 2024 •

edited

Loading

XuHuaiyu commented Jul 30, 2024 •

edited

Loading