-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: use history iterator to scan ddl jobs #54100
Conversation
Skipping CI for Draft Pull Request. |
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54100 +/- ##
=================================================
- Coverage 72.8399% 56.8392% -16.0008%
=================================================
Files 1516 1643 +127
Lines 434775 611676 +176901
=================================================
+ Hits 316690 347672 +30982
- Misses 98499 240326 +141827
- Partials 19586 23678 +4092
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
br/pkg/backup/client.go
Outdated
// no more jobs | ||
break | ||
} | ||
count += len(cacheJobs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should count
counts the filtered jobs? count += len(jobs)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #54139
Problem Summary:
sometimes cluster might have too many ddl jobs. backup should skip unnecessary scan of ddl jobs during the backup incremental ddls.
What changed and how does it work?
Use
GetLastHistoryDDLJobsIterator
instead ofGetAllDDLJobs
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.