Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: use history iterator to scan ddl jobs (#54100) #54933

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54100

What problem does this PR solve?

Issue Number: close #54139

Problem Summary:
sometimes cluster might have too many ddl jobs. backup should skip unnecessary scan of ddl jobs during the backup incremental ddls.

What changed and how does it work?

Use GetLastHistoryDDLJobsIterator instead of GetAllDDLJobs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2024
@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test check-dev

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/retest-required

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test unit-test

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test check-dev

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2024
Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test check-dev

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test unit-test

Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test unit-test

Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

3pointer commented Sep 2, 2024

/test unit-test

Copy link

tiprow bot commented Sep 2, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2024
@3pointer
Copy link
Contributor

3pointer commented Sep 3, 2024

/test unit-test

Copy link

ti-chi-bot bot commented Sep 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 09:09:06.33216138 +0000 UTC m=+262670.850214306: ☑️ agreed by YuJuncen.
  • 2024-09-03 04:28:10.490002665 +0000 UTC m=+332215.008055585: ☑️ agreed by 3pointer.

Copy link

tiprow bot commented Sep 3, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

3pointer commented Sep 3, 2024

/test unit-test

Copy link

ti-chi-bot bot commented Sep 3, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-ddl-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-6.5/ghpr_build
  • pingcap/tidb/release-6.5/ghpr_check
  • pingcap/tidb/release-6.5/ghpr_check2
  • pingcap/tidb/release-6.5/ghpr_mysql_test
  • pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Sep 3, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

3pointer commented Sep 3, 2024

/test unit-test

Copy link

tiprow bot commented Sep 3, 2024

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer 3pointer force-pushed the cherry-pick-54100-to-release-6.5 branch from d94c08e to c1ecfaa Compare September 3, 2024 10:25
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 81.13208% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@b06e1a9). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #54933   +/-   ##
================================================
  Coverage               ?   73.6377%           
================================================
  Files                  ?       1097           
  Lines                  ?     352659           
  Branches               ?          0           
================================================
  Hits                   ?     259690           
  Misses                 ?      76268           
  Partials               ?      16701           

@ti-chi-bot ti-chi-bot bot merged commit 1a305b3 into pingcap:release-6.5 Sep 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants