Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: incorrect query result using ISNULL #54819

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 23, 2024

What problem does this PR solve?

Issue Number: close #54803

Problem Summary:

What changed and how does it work?

points2EqOrInCond will generate the Equal/IN expression according the column info and const value. but we cannot regard isnull() and = null as equivalent. so isnull should skip the points2EqOrInCond.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei hawkingrei marked this pull request as draft July 23, 2024 03:19
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2024
@hawkingrei hawkingrei marked this pull request as ready for review July 24, 2024 09:39
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.0132%. Comparing base (d940b7d) to head (330435a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54819        +/-   ##
================================================
+ Coverage   72.7342%   74.0132%   +1.2789%     
================================================
  Files          1570       1571         +1     
  Lines        439504     440432       +928     
================================================
+ Hits         319670     325978      +6308     
+ Misses       100069      94178      -5891     
- Partials      19765      20276       +511     
Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4620% <ø> (+6.6332%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2024
@hawkingrei
Copy link
Member Author

/retest

pkg/util/ranger/detacher.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei hawkingrei removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
pkg/planner/core/casetest/plan_test.go Outdated Show resolved Hide resolved
pkg/util/ranger/detacher.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Signed-off-by: Weizhen Wang <[email protected]>
Copy link

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-07 06:08:12.024026235 +0000 UTC m=+418621.891125325: ☑️ agreed by winoros.
  • 2024-08-07 06:37:59.193217739 +0000 UTC m=+420409.060316824: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 395c6e7 into pingcap:master Aug 7, 2024
23 checks passed
@hawkingrei hawkingrei deleted the 54803 branch August 7, 2024 07:28
hawkingrei added a commit to hawkingrei/tidb that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect query result using ISNULL
4 participants