-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: incorrect query result using ISNULL #54819
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54819 +/- ##
================================================
+ Coverage 72.7342% 74.0132% +1.2789%
================================================
Files 1570 1571 +1
Lines 439504 440432 +928
================================================
+ Hits 319670 325978 +6308
+ Misses 100069 94178 -5891
- Partials 19765 20276 +511
|
/retest |
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Weizhen Wang <[email protected]>
Co-authored-by: Arenatlx <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #54803
Problem Summary:
What changed and how does it work?
points2EqOrInCond
will generate theEqual
/IN
expression according the column info and const value. but we cannot regardisnull()
and= null
as equivalent. soisnull
should skip thepoints2EqOrInCond
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.