-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: call SetText
correctly for CreateViewStmt
#55520
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
SetText
correctly for CreateViewStmt
SetText
correctly for CreateViewStmt
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55520 +/- ##
================================================
+ Coverage 72.9033% 75.1615% +2.2581%
================================================
Files 1576 1576
Lines 440819 444504 +3685
================================================
+ Hits 321372 334096 +12724
+ Misses 99705 90191 -9514
- Partials 19742 20217 +475
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, tangenta, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…e-upstream * origin/master: parser: call `SetText` correctly for `CreateViewStmt` (#55520) lighting: expose limited fields for `kv.Session` (#55517) show: prefilter table name with like pattern and show full tables (#55396) Planner: Do not allow cardinality to go below 1 (#55242) *: replace maps.Copy which is for map clone with std maps.Clone (#55530) infoschema: add WithRefillOption for TableByName and TableByID (#55511) domain: change groupSize in splitForConcurrentFetch (#55518) ddl: fix resuming to wrong checkpoint when failed during adding index (#55506)
What problem does this PR solve?
Issue Number: close #55441
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.