Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix issue that query slow_query table return wrong result #56356

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56100

Problem Summary: fix issue that query slow_query table return wrong result

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
Copy link

tiprow bot commented Sep 27, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.9752%. Comparing base (c7d09e6) to head (746ab46).
Report is 513 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56356         +/-   ##
=================================================
- Coverage   73.3187%   57.9752%   -15.3435%     
=================================================
  Files          1636       1789        +153     
  Lines        453659     659995     +206336     
=================================================
+ Hits         332617     382634      +50017     
- Misses       100668     251986     +151318     
- Partials      20374      25375       +5001     
Flag Coverage Δ
integration 39.7614% <8.6956%> (?)
unit 72.9283% <100.0000%> (+0.3978%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1585% <ø> (+17.1469%) ⬆️

@crazycs520 crazycs520 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
Copy link
Contributor Author

@lcwangchao @tiancaiamao PTAL

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 22, 2024
Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 10:29:12.441630852 +0000 UTC m=+346953.138421477: ☑️ agreed by Defined2014.
  • 2024-10-22 11:03:36.05532663 +0000 UTC m=+349016.752117258: ☑️ agreed by lcwangchao.

Copy link

tiprow bot commented Oct 22, 2024

@crazycs520: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 2a0b181 link true /test fast_test_tiprow
tidb_parser_test 2a0b181 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@crazycs520
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Oct 23, 2024

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@crazycs520
Copy link
Contributor Author

/merge

@crazycs520 crazycs520 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jan 6, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #58693.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58694.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58695.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #58696.

crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
crazycs520 added a commit to ti-chi-bot/tidb that referenced this pull request Jan 6, 2025
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jan 7, 2025
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

information_schema.cluster_slow_query returns wrong result
6 participants