-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix issue that query slow_query table return wrong result #56356
Conversation
Signed-off-by: crazycs520 <[email protected]>
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56356 +/- ##
=================================================
- Coverage 73.3187% 57.9752% -15.3435%
=================================================
Files 1636 1789 +153
Lines 453659 659995 +206336
=================================================
+ Hits 332617 382634 +50017
- Misses 100668 251986 +151318
- Partials 20374 25375 +5001
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@lcwangchao @tiancaiamao PTAL |
[LGTM Timeline notifier]Timeline:
|
@crazycs520: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/merge |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
This reverts commit c95ff2c.
…ingcap#56356) Signed-off-by: crazycs520 <[email protected]>
This reverts commit 037cd25.
…ingcap#56356) Signed-off-by: crazycs520 <[email protected]>
This reverts commit a9eae6e.
…ingcap#56356) Signed-off-by: crazycs520 <[email protected]>
…ingcap#56356) Signed-off-by: crazycs520 <[email protected]>
…ingcap#56356) Signed-off-by: crazycs520 <[email protected]>
What problem does this PR solve?
Issue Number: close #56100
Problem Summary: fix issue that query slow_query table return wrong result
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.