Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix issue that query slow_query table return wrong result | tidb-test=345b2782950dafda7b4a938c84bffb7f46834add #58726

Conversation

crazycs520
Copy link
Contributor

This is an hotfix of #56356

What problem does this PR solve?

Issue Number: close #56100

Problem Summary: fix issue that query slow_query table return wrong result

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
Copy link

tiprow bot commented Jan 7, 2025

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5-20250107-v7.5.1@7d16cc7). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.5-20250107-v7.5.1     #58726   +/-   ##
================================================================
  Coverage                               ?   75.9305%           
================================================================
  Files                                  ?       1418           
  Lines                                  ?     449412           
  Branches                               ?          0           
================================================================
  Hits                                   ?     341241           
  Misses                                 ?      88736           
  Partials                               ?      19435           
Flag Coverage Δ
unit 75.9305% <95.8333%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 57.8735% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 56.3342% <0.0000%> (?)

@crazycs520 crazycs520 changed the base branch from release-7.5 to release-7.5-20250107-v7.5.1 January 7, 2025 03:51
@crazycs520
Copy link
Contributor Author

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 7, 2025
Copy link

tiprow bot commented Jan 7, 2025

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 06:01:42.142571717 +0000 UTC m=+247045.431403422: ☑️ agreed by Defined2014.
  • 2025-01-07 06:02:03.836941242 +0000 UTC m=+247067.125772947: ☑️ agreed by lcwangchao.

@crazycs520
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Jan 7, 2025

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jebter jebter changed the title executor: fix issue that query slow_query table return wrong result (#56356) executor: fix issue that query slow_query table return wrong result | tidb-test=345b2782950dafda7b4a938c84bffb7f46834add Jan 7, 2025
@jebter
Copy link

jebter commented Jan 7, 2025

/retest

Copy link

tiprow bot commented Jan 7, 2025

@jebter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 7, 2025
@ti-chi-bot ti-chi-bot bot merged commit ac61374 into pingcap:release-7.5-20250107-v7.5.1 Jan 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants