-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix function substr with 3 arguments bug #1296
Merged
windtalker
merged 1 commit into
pingcap:master
from
marsishandsome:feature/fix-substring-bug
Dec 23, 2020
Merged
fix function substr with 3 arguments bug #1296
windtalker
merged 1 commit into
pingcap:master
from
marsishandsome:feature/fix-substring-bug
Dec 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
331e0a3
to
34f71a7
Compare
/run-all-tests |
34f71a7
to
0344711
Compare
/run-all-tests |
78f247b
to
e571416
Compare
/run-all-tests |
windtalker
reviewed
Dec 23, 2020
e571416
to
b0bd533
Compare
/run-all-tests |
windtalker
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-3.1 in PR #1300 |
cherry pick to release-4.0 in PR #1301 |
ti-srebot
added a commit
that referenced
this pull request
Dec 23, 2020
/run-cherry-picker |
cherry pick to release-5.0-rc in PR #1304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-cherry-pick-release-3.1
PR which needs to be cherry-picked to release-3.1
needs-cherry-pick-release-4.0
PR which needs to be cherry-picked to release-4.0
needs-cherry-pick-release-5.0-rc
PR which needs to be cherry-picked to release-5.0-rc
status/LGT1
Indicates that a PR has LGTM 1.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: tiflash funcion substr with 3 arguments has bug
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note