Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function substr with 3 arguments bug (#1296) #1300

Closed

Conversation

ti-srebot
Copy link
Collaborator

cherry-pick #1296 to release-3.1


What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: tiflash funcion substr with 3 arguments has bug

create table t (c varchar(64));
ALTER TABLE t SET TIFLASH REPLICA 1;
insert into t values ("ABC"), ("DEF"), ("");
insert into t select * from t;
insert into t select * from t;
insert into t select * from t;
insert into t select * from t;
insert into t select * from t;
insert into t select * from t;

analyze table t;
select substr(c, 2), count(1) from t group by substr(c, 2);

image

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2020
@ti-srebot ti-srebot added this to the v3.1.3 milestone Dec 23, 2020
@marsishandsome
Copy link
Contributor

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants