Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: Fix returned column types may not match in late-materialization #9176

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Storages: Fix returned column types may not match in late-materialization #9176

merged 3 commits into from
Jul 3, 2024

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jul 2, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9175

Problem Summary: #9175

+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+
| id                     | estRows | task         | access object | operator info                                                      |
+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+
| TableReader_13         | 128.00  | root         |               | MppVersion: 2, data:ExchangeSender_12                              |
| └─ExchangeSender_12    | 128.00  | mpp[tiflash] |               | ExchangeType: PassThrough                                          |
|   └─Projection_5       | 128.00  | mpp[tiflash] |               | hour(test.t.a)->Column#4, test.t.i                                 |
|     └─TableFullScan_10 | 128.00  | mpp[tiflash] | table:t       | pushed down filter:eq(test.t.a, 24:11:11.123500), keep order:false |
+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue of column types that may not match in late-materialization.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2024
@JinheLin JinheLin requested review from JaySon-Huang and Lloyd-Pottiger and removed request for JaySon-Huang July 2, 2024 09:02
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 2, 2024
@JinheLin JinheLin requested a review from JaySon-Huang July 3, 2024 00:58
JaySon-Huang
JaySon-Huang approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-02 09:19:13.27136685 +0000 UTC m=+1316079.756855683: ☑️ agreed by Lloyd-Pottiger.
  • 2024-07-03 06:31:54.479815591 +0000 UTC m=+1392440.965304424: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 567bcb1 into pingcap:master Jul 3, 2024
4 of 5 checks passed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 3, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 3, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#9176
6a91a03 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9180.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9181.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 3, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#9176
9145657 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 3, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#9176
27299af 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9182.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2024
Merged
12 tasks
@JinheLin JinheLin deleted the fix_column_type branch July 4, 2024 14:34
ti-chi-bot bot added a commit that referenced this pull request Jul 9, 2024
@ti-chi-bot @JinheLin @ti-chi-bot
Storages: Fix returned column types may not match in late-materializa…
99cc092 
…tion (#9176) (#9181)

close #9175

Signed-off-by: ti-chi-bot <[email protected]>

Co-authored-by: jinhelin <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Jul 10, 2024
@ti-chi-bot @JinheLin @ti-chi-bot
Storages: Fix returned column types may not match in late-materializa…
f48a645 
…tion (#9176) (#9180)

close #9175

Signed-off-by: ti-chi-bot <[email protected]>

Co-authored-by: jinhelin <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2024
@ti-chi-bot @JinheLin @Lloyd-Pottiger
Storages: Fix returned column types may not match in late-materializa…
826cd9d 
…tion (#9176) (#9182)

close #9175

Signed-off-by: ti-chi-bot <[email protected]>

Co-authored-by: jinhelin <[email protected]>
Co-authored-by: Lloyd-Pottiger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Illegal column Int64 of first argument of function hour
4 participants
@JinheLin @ti-chi-bot @JaySon-Huang @Lloyd-Pottiger