Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storages: Fix returned column types may not match in late-materialization (#9176) #9181

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9176

What problem does this PR solve?

Issue Number: close #9175

Problem Summary: #9175

What is changed and how it works?


+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+
| id                     | estRows | task         | access object | operator info                                                      |
+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+
| TableReader_13         | 128.00  | root         |               | MppVersion: 2, data:ExchangeSender_12                              |
| └─ExchangeSender_12    | 128.00  | mpp[tiflash] |               | ExchangeType: PassThrough                                          |
|   └─Projection_5       | 128.00  | mpp[tiflash] |               | hour(test.t.a)->Column#4, test.t.i                                 |
|     └─TableFullScan_10 | 128.00  | mpp[tiflash] | table:t       | pushed down filter:eq(test.t.a, 24:11:11.123500), keep order:false |
+------------------------+---------+--------------+---------------+--------------------------------------------------------------------+

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue of column types that may not match in late-materialization.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jul 3, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 3, 2024
@JinheLin
Copy link
Contributor

JinheLin commented Jul 9, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-09 06:21:38.517269089 +0000 UTC m=+338595.752503203: ☑️ agreed by JinheLin.
  • 2024-07-09 06:31:52.848152362 +0000 UTC m=+339210.083386476: ☑️ agreed by Lloyd-Pottiger.

@JinheLin
Copy link
Contributor

JinheLin commented Jul 9, 2024

/run-all-tests

@JinheLin
Copy link
Contributor

JinheLin commented Jul 9, 2024

[2024-07-09T08:02:16.126Z] rg1_cpu_time 2249
[2024-07-09T08:02:16.126Z] rg2_cpu_time 1826
[2024-07-09T08:02:16.126Z] rate 0.811916
[2024-07-09T08:02:16.126Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/Pipeline/Schedule/TaskQueues/tests/gtest_resource_control_queue.cpp:483: Failure
[2024-07-09T08:02:16.126Z] Value of: rate > 1
[2024-07-09T08:02:16.126Z]   Actual: false
[2024-07-09T08:02:16.126Z] Expected: true
[2024-07-09T08:02:16.126Z] �[0;31m[  FAILED  ] �[mTestResourceControlQueue.SmallRULargeCPUDynamicTokenBucket (5876 ms)
[2024-07-09T08:02:16.126Z] �[0;32m[----------] �[m1 test from TestResourceControlQueue (5876 ms total)
[2024-07-09T08:02:16.126Z] 
[2024-07-09T08:02:16.126Z] �[0;32m[----------] �[mGlobal test environment tear-down
[2024-07-09T08:02:16.126Z] �[0;32m[==========] �[m1 test from 1 test case ran. (5877 ms total)
[2024-07-09T08:02:16.126Z] �[0;32m[  PASSED  ] �[m0 tests.
[2024-07-09T08:02:16.126Z] �[0;31m[  FAILED  ] �[m1 test, listed below:
[2024-07-09T08:02:16.126Z] �[0;31m[  FAILED  ] �[mTestResourceControlQueue.SmallRULargeCPUDynamicTokenBucket
[2024-07-09T08:02:16.126Z] 
[2024-07-09T08:02:16.126Z]  1 FAILED TEST

@JinheLin
Copy link
Contributor

JinheLin commented Jul 9, 2024

/run-unit-test

@JinheLin
Copy link
Contributor

JinheLin commented Jul 9, 2024

[2024-07-09T10:13:07.575Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/KVStore/tests/gtest_raftstore_v2.cpp:361: Failure
[2024-07-09T10:13:07.575Z] Expected equality of these values:
[2024-07-09T10:13:07.575Z]   res.stats.parallels
[2024-07-09T10:13:07.575Z]     Which is: 0
[2024-07-09T10:13:07.575Z]   4
[2024-07-09T10:13:07.575Z] [2024/07/09 18:13:06.285 +08:00] [ERROR] [Exception.cpp:96] ["std::exception. Code: 1001, type: testing::AssertionException, e.what() = /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/KVStore/tests/gtest_raftstore_v2.cpp:361: Failure\nExpected equality of these values:\n  res.stats.parallels\n    Which is: 0\n  4"] [source="virtual void DB::tests::RegionKVStoreTest_KVStoreSingleSnap4_Test::TestBody()"] [thread_id=1]
[2024-07-09T10:13:07.575Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/KVStore/tests/gtest_raftstore_v2.cpp:374: Failure
[2024-07-09T10:13:07.575Z] Failed
[2024-07-09T10:13:07.575Z] �[0;31m[  FAILED  ] �[mRegionKVStoreTest.KVStoreSingleSnap4 (75 ms)
[2024-07-09T10:13:07.575Z] �[0;32m[----------] �[m1 test from RegionKVStoreTest (75 ms total)
[2024-07-09T10:13:07.575Z] 
[2024-07-09T10:13:07.575Z] �[0;32m[----------] �[mGlobal test environment tear-down
[2024-07-09T10:13:07.576Z] �[0;32m[==========] �[m1 test from 1 test case ran. (77 ms total)
[2024-07-09T10:13:07.576Z] �[0;32m[  PASSED  ] �[m0 tests.
[2024-07-09T10:13:07.576Z] �[0;31m[  FAILED  ] �[m1 test, listed below:
[2024-07-09T10:13:07.576Z] �[0;31m[  FAILED  ] �[mRegionKVStoreTest.KVStoreSingleSnap4
[2024-07-09T10:13:07.576Z] 
[2024-07-09T10:13:07.576Z]  1 FAILED TEST

@JinheLin
Copy link
Contributor

JinheLin commented Jul 9, 2024

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 99cc092 into pingcap:release-7.5 Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants