schema storage shallow copy DBInfo (#3085)

* schema storage shallow copy DBInfo Signed-off-by: sdojjy <[email protected]> * schema storage shallow copy DBInfo
pingcap · Nov 3, 2021 · de2fca8 · de2fca8
1 parent 9157bb4
commit de2fca8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/cdc/entry/schema_storage.go b/cdc/entry/schema_storage.go
@@ -226,7 +226,8 @@ func (s *schemaSnapshot) Clone() *schemaSnapshot {
 
 	schemas := make(map[int64]*timodel.DBInfo, len(s.schemas))
 	for k, v := range s.schemas {
-		schemas[k] = v.Clone()
+		// DBInfo is readonly in TiCDC, shallow copy to reduce memory
+		schemas[k] = v.Copy()
 	}
 	clone.schemas = schemas
 
@@ -389,7 +390,7 @@ func (s *schemaSnapshot) createSchema(db *timodel.DBInfo) error {
 		return cerror.ErrSnapshotSchemaExists.GenWithStackByArgs(db.Name, db.ID)
 	}
 
-	s.schemas[db.ID] = db.Clone()
+	s.schemas[db.ID] = db.Copy()
 	s.schemaNameToID[db.Name.O] = db.ID
 	s.tableInSchema[db.ID] = []int64{}
 
@@ -402,7 +403,7 @@ func (s *schemaSnapshot) replaceSchema(db *timodel.DBInfo) error {
 	if !ok {
 		return cerror.ErrSnapshotSchemaNotFound.GenWithStack("schema %s(%d) not found", db.Name, db.ID)
 	}
-	s.schemas[db.ID] = db.Clone()
+	s.schemas[db.ID] = db.Copy()
 	s.schemaNameToID[db.Name.O] = db.ID
 	return nil
 }