Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema storage shallow copy DBInfo #3085

Merged
merged 2 commits into from
Nov 3, 2021
Merged

schema storage shallow copy DBInfo #3085

merged 2 commits into from
Nov 3, 2021

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Oct 19, 2021

Signed-off-by: sdojjy [email protected]

What problem does this PR solve?

In TiCDC DBInfo is ready only data, to reduce memory, we can use DBInfo.Copy() method to shallow copy DBInfo

What is changed and how it works?

replace DBInfo.Clone() with DBInfo.Copy()

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

 None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2021
overvenus
overvenus reviewed Oct 19, 2021
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/entry/schema_storage.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Oct 21, 2021

/run-kafka-tests

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Oct 21, 2021

/run-kafka-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 22, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Oct 22, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dbd34c5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

4 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@sdojjy
Copy link
Member Author

sdojjy commented Oct 25, 2021

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@sdojjy
Copy link
Member Author

sdojjy commented Nov 2, 2021

/run-kafka-tests

@pingcap pingcap deleted a comment from amyangfei Nov 2, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Nov 2, 2021

/run-kafka-tests

@overvenus
Copy link
Member

/run-kafka-integration-test

@overvenus overvenus removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2021
@overvenus overvenus merged commit de2fca8 into pingcap:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus left review comments

@amyangfei amyangfei amyangfei approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sdojjy @ti-chi-bot @amyangfei @overvenus @asddongmen