Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support output raw change event for mq and cloud storage sink #11211

Closed
CharlesCheung96 opened this issue May 31, 2024 · 0 comments · Fixed by #11226
Closed

Support output raw change event for mq and cloud storage sink #11211

CharlesCheung96 opened this issue May 31, 2024 · 0 comments · Fixed by #11226
Assignees
@CharlesCheung96
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.

Comments

@CharlesCheung96
Copy link
Contributor

CharlesCheung96 commented May 31, 2024 •
edited
Loading

Background

Since LTS releases v6.5.3, v7.1.1, v7.5.x and v8.1.x, TiCDC splits update event into delete and insert events if the primary key or non-null unique index value is modified in the event. This change primarily addresses the potential issue of primary key conflicts when using the MySQL sink. For more information about the behavior change, see the official document.
However, some kafka users have been affected by this behavior change, since their consumption logic only recognizes update changes. Therefore, it is necessary to add a parameter so that the cdc can maintain the behavior of the old version.

Solution

Add a parameter output-raw-change-event for kafka and cloud storage sink.

  1. output-raw-change-event = false, update pk/uk events is split.
  2. output-raw-change-event = true, update pk/uk events is not split. In this case, the consumer is required to ensure data consistency.
@CharlesCheung96 CharlesCheung96 added the type/bug The issue is confirmed as a bug. label May 31, 2024
@CharlesCheung96 CharlesCheung96 added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major and removed affects-6.1 This bug affects the 6.1.x(LTS) versions. labels May 31, 2024
@CharlesCheung96 CharlesCheung96 self-assigned this May 31, 2024
@CharlesCheung96 CharlesCheung96 changed the title Support output raw change event for kafka and cloud storage sink Support output raw change event for mq and cloud storage sink Jun 3, 2024
@CharlesCheung96 CharlesCheung96 mentioned this issue Jun 3, 2024
Merged
@CharlesCheung96 CharlesCheung96 added area/ticdc Issues or PRs related to TiCDC. and removed may-affects-5.4 may-affects-6.1 labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 3887861 Jun 11, 2024
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 11, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
c092599 
…loud storage sink (#11226) (#11290)

close #11211
@CharlesCheung96 CharlesCheung96 mentioned this issue Jun 12, 2024
Open
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Jun 12, 2024
@hicqu
Squashed commit of the following:
a3d30ca 
commit c092599
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 12 00:26:59 2024 +0800

    pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290)

    close pingcap#11211

commit 3426e46
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 19:40:29 2024 +0800

    puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282)

    close pingcap#11219

commit 2a28078
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 16:40:37 2024 +0800

    mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261)

    close pingcap#11213

commit 2425d54
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 16:40:30 2024 +0800

    log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257)

    close pingcap#11254

commit 053cdaf
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 15:34:30 2024 +0800

    cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287)

    close pingcap#11271

commit 327ba7b
Author: Ti Chi Robot <[email protected]>
Date:   Tue Jun 11 11:42:00 2024 +0800

    redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091)

    close pingcap#10124

commit d82ae89
Author: Ti Chi Robot <[email protected]>
Date:   Mon Jun 10 22:28:29 2024 +0800

    ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981)

    close pingcap#10890

commit f15bec9
Author: Ti Chi Robot <[email protected]>
Date:   Fri Jun 7 16:16:28 2024 +0800

    redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996)

    close pingcap#10900

commit ba50a0e
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 19:58:26 2024 +0800

    test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037)

    close pingcap#11015

commit 94b9897
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 17:08:56 2024 +0800

    mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946)

    close pingcap#10931

commit a912d33
Author: Ti Chi Robot <[email protected]>
Date:   Wed Jun 5 10:49:25 2024 +0800

    mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242)

    close pingcap#11241

commit 6277d9a
Author: dongmen <[email protected]>
Date:   Wed May 29 20:13:22 2024 +0800

    kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184)

    close pingcap#11073

commit 54e93ed
Author: dongmen <[email protected]>
Date:   Wed May 29 17:43:22 2024 +0800

    syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162)

    close pingcap#10516

commit 0ba9329
Author: Ti Chi Robot <[email protected]>
Date:   Wed May 29 09:07:21 2024 +0800

    (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180)

    close pingcap#11096

Signed-off-by: qupeng <[email protected]>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jul 15, 2024
@CharlesCheung96
pkg/config, sink(ticdc): support output raw change event for mq and c…
909c001 
…loud storage sink (pingcap#11226)

close pingcap#11211
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jul 15, 2024
@CharlesCheung96
pkg/config, sink(ticdc): support output raw change event for mq and c…
d970f03 
…loud storage sink (pingcap#11226)

close pingcap#11211
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this issue Jul 15, 2024
@CharlesCheung96
pkg/config, sink(ticdc): support output raw change event for mq and c…
a77670a 
…loud storage sink (pingcap#11226)

close pingcap#11211
ti-chi-bot bot pushed a commit that referenced this issue Jul 17, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
6395bdd 
…loud storage sink (#11226) (#11292)

close #11211
ti-chi-bot bot pushed a commit that referenced this issue Jul 17, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
9e93510 
…loud storage sink (#11226) (#11291)

close #11211
ti-chi-bot bot pushed a commit that referenced this issue Aug 2, 2024
@ti-chi-bot
pkg/config, sink(ticdc): support output raw change event for mq and c…
6cf7f46 
…loud storage sink (#11226) (#11293)

close #11211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlesCheung96 CharlesCheung96

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
1 participant
@CharlesCheung96