Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (#11226) #11293

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11226

What problem does this PR solve?

Issue Number: close #11211

What is changed and how it works?

  1. Add output-raw-change-event to KafkaConfig, PulsarConfig and CloudStorageConfig.
  2. When outputRawChangeEvent=true, do not split update in table sink.
  3. Add integration tests to cover the outputRawChangeEvent congiuration.

TODO: Kafka and Pulsar related integration tests will be added in another pull request.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes

Release note

`support output raw change event for mq and cloud storage sink `.

@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 67.62590% with 45 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@3beaea5). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 62.6194% <0.0000%> (?)
dm 51.4630% <0.0000%> (?)
engine 63.4585% <0.0000%> (?)
Flag Coverage Δ
unit 58.0027% <67.6259%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11293   +/-   ##
================================================
  Coverage               ?   58.0027%           
================================================
  Files                  ?        853           
  Lines                  ?     127363           
  Branches               ?          0           
================================================
  Hits                   ?      73874           
  Misses                 ?      48059           
  Partials               ?       5430           

@CharlesCheung96 CharlesCheung96 requested a review from sdojjy July 15, 2024 06:21
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 1, 2024
@CharlesCheung96
Copy link
Contributor

/retest

3 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6cf7f46 into pingcap:release-8.1 Aug 2, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants