-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_*: add a HTTP API to list changefeed info #1917
Conversation
…o changefeed_http_api
I will fix the failed tests as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better put in a new file
/run-unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Co-authored-by: Zixiong Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 42a2518
|
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
================================================
+ Coverage 53.8503% 54.0910% +0.2406%
================================================
Files 155 164 +9
Lines 16479 17404 +925
================================================
+ Hits 8874 9414 +540
- Misses 6655 6985 +330
- Partials 950 1005 +55 |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #1955. |
/run-cherry-picker |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #2022. |
What problem does this PR solve?
#1869
What is changed and how it works?
Add a HTTP API to list changefeed info.
Add a HTTP API to check the health of CDC server. (It only return a response with 200 OK and empty body.)
Check List
Tests
Code changes
Side effects
Related changes
Release note