-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_*: add a HTTP API to list changefeed info (#1917) #2022
http_*: add a HTTP API to list changefeed info (#1917) #2022
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 607f241
|
/run-all-tests |
/run-leak-tests |
/run-integration-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
cdc/http_handler.go
Outdated
} else { | ||
if s.captureV2 == nil { | ||
// for test only | ||
handleOwnerResp(w, concurrency.ErrElectionNotLeader) | ||
return | ||
} | ||
} | ||
|
||
if s.captureV2 == nil { | ||
// for test only | ||
handleOwnerResp(w, concurrency.ErrElectionNotLeader) | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be cherry picked to release-4.0, PTAL @asddongmen
/merge |
/run-leak-tests |
This is an automated cherry-pick of #1917
What problem does this PR solve?
#1869
What is changed and how it works?
Add a HTTP API to list changefeed info.
Add a HTTP API to check the health of CDC server. (It only return a response with 200 OK and empty body.)
Check List
Tests
Code changes
Side effects
Related changes
Release note