Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: deprecate the removed changefeed state (#1990) #2056

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1990

What problem does this PR solve?

before this pr, the changefeed state is very complex, now we have simplified the state representation, remove the Removed state.

the changefeed state transfer:
ticdc-state-transfer

① execute changefeed pause
② execute changefeed resume
③ changefeed throw a recoverable errors
④ execute changefeed resume
⑤ changefeed throw a unrecoverable errors
⑥ The sync task has reached the preset TargetTs and the sync is automatically stopped

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. do-not-merge/cherry-pick-not-approved labels Jun 15, 2021
@ti-chi-bot ti-chi-bot requested a review from overvenus June 15, 2021 13:39
@ti-chi-bot ti-chi-bot requested review from amyangfei and zier-one June 15, 2021 13:39
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2021
@amyangfei amyangfei added this to the v4.0.14 milestone Jun 16, 2021
@amyangfei amyangfei removed the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 16, 2021
@zier-one
Copy link
Contributor

merged by #2123

@zier-one zier-one closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants