Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_owner: merge the new owner to 4.0 #2123

Merged
merged 29 commits into from
Jun 23, 2021
Merged

new_owner: merge the new owner to 4.0 #2123

merged 29 commits into from
Jun 23, 2021

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 22, 2021 •
edited
Loading

What problem does this PR solve?

cherry-pick the new owner to 4.0 branch

Release note

  • No release note

leoppro added 27 commits June 22, 2021 13:57
*: refine the vars in context.Context (pingcap#1459)
a187fdf
context: uniform the import naming of context, part 1 (pingcap#1773)
425393f
etcd_worker: support update multi-keys in a DataPatch (pingcap#1747)
5cad017
new_owner: let processor and owner use the same reactor state (pingca…
ee22aff 
…p#1810)
etcd_worker: fix a bug that etcd worker maybe lost data at starting (p…
a0df868 
…ingcap#1813)
new_owner: a schema wrapper for owner (pingcap#1766)
4eb7018
new_owner: implement gc manager (pingcap#1819)
619b810
new_owner: a ddl puller wrapper for owner (pingcap#1776)
3d616ac
new_owner: an async sink for owner (pingcap#1782)
0ba25df
new_owner: a feed state manager for owner (pingcap#1826)
7ca2e89
new_owner: a table task scheduler for the owner (pingcap#1820)
18038fd
new owner: port metrics from the old owner (pingcap#1886)
00b7efc
new_owner: refine processor (pingcap#1821)
c80e58f
new_owner: a changefeed implement (pingcap#1894)
1892868
new_owner: a owner implement, the owner is a manager of changefeeds (p…
c78c8b5 
…ingcap#1909)
new_owner: a capture implement, the capture manages and runs the owne…
9dd7ab7 
…r and processor (pingcap#1914)
new_owner: switch on the new owner (pingcap#1927)
90a0fef
tests: fix a unstable test in CI (pingcap#1940)
cd1bce5
owner: fix a changefeed can not removed when the changefeed status is…
581b86d 
… not exist (pingcap#1952)
owner: fix the owner panic (pingcap#1964)
f88913f
owner: fix owner ship metrics (pingcap#1980)
97ccb8e
*: fix err docs (pingcap#1989)
c14f0f8
owner: fix some nil panic when switch off the new owner (pingcap#2004)
e09c082
owner: fix etcd error too many operations in txn request (pingcap#1988)
7044413
owner: check the version of the ticdc cluster (pingcap#2003)
d942390
gc_manager: refine update gc service safe point (pingcap#2029)
288beb1
owner: deprecate the removed changefeed state (pingcap#1990)
dcf4bbd
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 22, 2021
This was referenced Jun 22, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@zier-one zier-one marked this pull request as ready for review June 22, 2021 06:53
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2021
@zier-one zier-one added the status/ptal Could you please take a look? label Jun 22, 2021
@zier-one
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added this to the v4.0.14 milestone Jun 22, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2021
@ti-chi-bot
Copy link
Member

@jinlingchristopher: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 23, 2021
@zier-one zier-one added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 23, 2021
@zier-one
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d0108ab

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot
Copy link
Member

@leoppro: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2123 (6f64f80) into release-4.0 (753073a) will decrease coverage by 0.1593%.
The diff coverage is 62.2763%.

@@                 Coverage Diff                 @@
##           release-4.0      #2123        +/-   ##
===================================================
- Coverage      53.7661%   53.6067%   -0.1594%     
===================================================
  Files              153        163        +10     
  Lines            15958      17287      +1329     
===================================================
+ Hits              8580       9267       +687     
- Misses            6475       7040       +565     
- Partials           903        980        +77

@ti-chi-bot ti-chi-bot merged commit 4f76708 into pingcap:release-4.0 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@liuzix liuzix liuzix approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.14
Development

Successfully merging this pull request may close these issues.
7 participants
@zier-one @ti-chi-bot @codecov-commenter @amyangfei @3AceShowHand @liuzix @lonng