dm(ui): support start/pause/resume/delete task #4412
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
zoubingwu
changed the title
| @@ -93,9 +96,10 @@ | |||
| "source name": "名称", | |||
| "source name is required": "名称不能为空", | |||
| "start import": "开始导入", | |||
| "start task": "启动任务", | |||
| "start task and remove meta data": "清理元数据启动", | |||
There was a problem hiding this comment.
| "start task and remove meta data": "清理元数据启动", | |
| "start task and remove meta data": "启动同步任务并清理元数据", |
| @@ -24,7 +24,7 @@ const BlinkingText: React.FC<{ text: string; active: boolean }> = ({ | |||
|
|
|||
| useEffect(() => { | |||
| if (active) { | |||
| timer.current = window.setInterval(() => setCount(c => c + 1), 300) | |||
| timer.current = window.setInterval(() => setCount(c => (c + 1) % 4), 300) | |||
There was a problem hiding this comment.
Because of this change, the line 39 can be simplified to return <span>{text + '.'.repeat(count)}</span>
|
@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
@Ehco1996: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Ehco1996
changed the title
|
/check-issue-triage-complete |
1 similar comment
|
/check-issue-triage-complete |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 4bde98b
|
ti-chi-bot
added
the
status/can-merge
|
/run-verify |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4412 +/- ##
================================================
- Coverage 55.6402% 55.4976% -0.1426%
================================================
Files 494 498 +4
Lines 61283 61790 +507
================================================
+ Hits 34098 34292 +194
- Misses 23750 24066 +316
+ Partials 3435 3432 -3 |
What problem does this PR solve?
Add methods to start/pause/resume/delete task.
Issue Number: ref #3583
What is changed and how it works?
Add buttons and event handlers
Check List
Tests
Release note