-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm(ui): support start/pause/resume/delete task #4412
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
74a6e40
feat: start task
zoubingwu 66bda6d
fix: fix save task config
zoubingwu b5384a8
feat: edit task config
zoubingwu 2f7da3c
refactor: extract props to method
zoubingwu e0b0d88
fix: use mod operation to avoid overflow
zoubingwu 4b2c01c
fix: update api url
zoubingwu 4bde98b
Merge branch 'master' into dev
Ehco1996 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ const BlinkingText: React.FC<{ text: string; active: boolean }> = ({ | |
|
||
useEffect(() => { | ||
if (active) { | ||
timer.current = window.setInterval(() => setCount(c => c + 1), 300) | ||
timer.current = window.setInterval(() => setCount(c => (c + 1) % 4), 300) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because of this change, the line 39 can be simplified to |
||
} | ||
return () => { | ||
if (timer.current) { | ||
|
@@ -49,7 +49,7 @@ const BatchImportTaskConfig: React.FC = () => { | |
const [overwrite, setOverwrite] = useState(false) | ||
const [batchImportTaskConfig] = useDmapiBatchImportTaskConfigMutation() | ||
const timerId = useRef<number>() | ||
const stopTimer = useRef<boolean>(false) | ||
const stopTimer = useRef(false) | ||
|
||
const calcStepStatus = (thisStep: number): Pick<StepProps, 'status'> => { | ||
if (currentStep === thisStep) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.