cmd: support pause/resume/remove changefeed #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
|
/run-integration-tests |
Signed-off-by: Neil Shen <[email protected]>
|
/run-integration-tests |
zier-one
reviewed
May 9, 2020
cdc/http_status.go
Outdated
| go func() { | ||
| err := s.statusServer.ListenAndServe() | ||
| ln, err := net.Listen("tcp", addr) |
There was a problem hiding this comment.
move this line out of this goroutine? we can avoid to using error channel
Signed-off-by: Neil Shen <[email protected]>
…to cli/manage-changefeed
|
/run-integration-tests PTAL, thanks |
amyangfei
reviewed
May 9, 2020
Signed-off-by: Neil Shen <[email protected]>
|
/run-integration-tests |
overvenus
referenced
this pull request
in overvenus/tiup-cluster
May 9, 2020
CDC is going to replace `status-add` with `addr` and `advertise-addr` in pingcap/ticdc#546.
Signed-off-by: Neil Shen <[email protected]>
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
================================================
+ Coverage 31.4302% 31.8208% +0.3905%
================================================
Files 70 70
Lines 6831 6854 +23
================================================
+ Hits 2147 2181 +34
+ Misses 4525 4512 -13
- Partials 159 161 +2 |
Signed-off-by: Neil Shen <[email protected]>
|
/run-integration-tests |
amyangfei
added
LGT2
subject/usability
|
btw, as this PR changes |
overvenus
referenced
this pull request
in pingcap/tipocket
May 11, 2020
overvenus
referenced
this pull request
in pingcap/docs-cn
May 11, 2020
5 tasks
5 tasks
zhouqiang-cl
referenced
this pull request
in pingcap/tipocket
May 11, 2020
5 tasks
5 tasks
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
* cdc, cmd: add status address to capture info Signed-off-by: Neil Shen <[email protected]> * tests: adjust start_cdc_server Signed-off-by: Neil Shen <[email protected]> * cmd: support pause/resume/remove changefeed Signed-off-by: Neil Shen <[email protected]> * fix test Signed-off-by: Neil Shen <[email protected]> * address comments Signed-off-by: Neil Shen <[email protected]> * cdc, cmd: replace status address with address and advertise address Signed-off-by: Neil Shen <[email protected]> * correct parameter Signed-off-by: Neil Shen <[email protected]> * use address in PD Signed-off-by: Neil Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cc pingcap/ticdc#542
Check List
Tests
Code changes
Related changes
Release note