Skip to content

Commit

Permalink
Revert "[Backport][Ray Dashboard] make memory profile href link relat… (
Browse files Browse the repository at this point in the history
#23)

…ive path (ray-project#46564) (#15)"

This reverts commit 1531ab3.

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Saurabh Vishwas Joshi <[email protected]>
  • Loading branch information
lee1258561 authored and Saurabh Vishwas Joshi committed Oct 31, 2024
1 parent 96ba808 commit 791c793
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dashboard/client/src/common/ProfilingLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export const MemoryProfilingButton = ({
if (!pid || !ip) {
return <div></div>;
}
const profilerUrl = `memory_profile?pid=${pid}&ip=${ip}`;
const profilerUrl = `/memory_profile?pid=${pid}&ip=${ip}`;

return <ProfilerButton profilerUrl={profilerUrl} type={type} />;
};
Expand All @@ -325,7 +325,7 @@ export const TaskMemoryProfilingButton = ({
if (!taskId) {
return null;
}
const profilerUrl = `memory_profile?task_id=${taskId}&attempt_number=${attemptNumber}&node_id=${nodeId}`;
const profilerUrl = `/memory_profile?task_id=${taskId}&attempt_number=${attemptNumber}&node_id=${nodeId}`;

return <ProfilerButton profilerUrl={profilerUrl} />;
};

0 comments on commit 791c793

Please sign in to comment.