[Backport][Ray Dashboard] make memory profile href link relative path (#46564) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#46564) When we host ray dashboard behind a prefix URL Path e.g. https://<some>.<ray>.<domain_name>/ray_dashboard/ it's important to use relative href link instead of having a forward slash / to prevent reset the URL Path , this change is to ensure consistent behavior with other similar profiling URL such as cpu profile and traceback ideally we want https://<some>.<ray>.<domain_name>/ray_dashboard/memory_profile... instead of https://<some>.<ray>.<domain_name>/memory_profile...
lee1258561
changed the title
lee1258561
approved these changes
Aug 16, 2024
lee1258561
added a commit
that referenced
this pull request
Sep 7, 2024
…ive path (ray-project#46564) (#15)" This reverts commit 1531ab3.
8 tasks
lee1258561
added a commit
that referenced
this pull request
Sep 7, 2024
#23) …ive path (ray-project#46564) (#15)" This reverts commit 1531ab3. <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(
sjoshi6
pushed a commit
that referenced
this pull request
Oct 31, 2024
…ray-project#46564) (#15) When we host ray dashboard behind a prefix URL Path e.g. https://<some>.<ray>.<domain_name>/ray_dashboard/ it's important to use relative href link instead of having a forward slash / to prevent reset the URL Path , this change is to ensure consistent behavior with other similar profiling URL such as cpu profile and traceback ideally we want https://<some>.<ray>.<domain_name>/ray_dashboard/memory_profile... instead of https://<some>.<ray>.<domain_name>/memory_profile... <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Co-authored-by: Chia-Wei <[email protected]> Signed-off-by: Saurabh Vishwas Joshi <[email protected]>
sjoshi6
pushed a commit
that referenced
this pull request
Oct 31, 2024
#23) …ive path (ray-project#46564) (#15)" This reverts commit 1531ab3. <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( Signed-off-by: Saurabh Vishwas Joshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we host ray dashboard behind a prefix URL Path e.g. https://..<domain_name>/ray_dashboard/ it's important to use relative href link instead of having a forward slash / to prevent reset the URL Path , this change is to ensure consistent behavior with other similar profiling URL such as cpu profile and traceback
ideally we want https://..<domain_name>/ray_dashboard/memory_profile... instead of https://..<domain_name>/memory_profile...
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.