Update layout.html #1554
Update layout.html #1554
Conversation
yardos
commented
Aug 30, 2017
yardos
commented
- removed (commented) old Google Analytics code
- added two snippets for Google Tag Manager (GTM), one in , the other in
* removed (commented) old Google Analytics code * added two snippets for Google Tag Manager (GTM), one in <head>, the other in <body>
|
@menshikh-iv the tests are failing but I don't see any problem with the changes. Can you check? |
|
@piskvorky Here flake8 check non-py files, I fix this incorrect behavior in #1522. |
|
@menshikh-iv No need for hot-fix, I'll test this PR by regenerating the docs and uploading to a separate website dir ("manual test"). Should get to it later today after meetings. If the CI issue is solved elsewhere, that's enough. But we should merge #1522 ASAP, that must be confusing to new contributors! |
|
Agree, I'll merge #1522 soon (when I finished with ipynb). |
|
@yardos I uploaded the generated docs to https://radimrehurek.com/dostal_gensim/ Chrome inspector reports some errors (404 for |
| ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js'; | ||
| var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s); | ||
| })(); | ||
| <script type="text/javascript"> // only commented for the moment - JD-20170830 |
There was a problem hiding this comment.
It's better to remove code than to comment it out.
The full history is stored, versioned and archived by git anyway, in case we ever need to go back. Like this we only bloat up the pages for no reason (slower page download, harder to read source, more room for error).
|
Current test error connected with old bug that already fixed in |
|
Oh, this PR is against @yardos , can you please open the PR against the |
