Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout.html #1554

Closed
wants to merge 2 commits into from
Closed

Update layout.html #1554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
205b27d
Update layout.html
yardos Aug 30, 2017
0628fcc
Ignore *.html for flake8
menshikh-iv Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion continuous_integration/travis/flake8_diff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,6 @@ check_files() {
if [[ "$MODIFIED_FILES" == "no_match" ]]; then
echo "No file has been modified"
else
check_files "$(echo "$MODIFIED_FILES" )" "--ignore=E501,E731,E12,W503 --exclude=*.sh,*.md,*.yml,*.rst,*.ipynb,*.txt,*.csv,*.vec,Dockerfile*,*.c,*.pyx,*.inc"
check_files "$(echo "$MODIFIED_FILES" )" "--ignore=E501,E731,E12,W503 --exclude=*.sh,*.md,*.yml,*.rst,*.ipynb,*.txt,*.csv,*.vec,Dockerfile*,*.c,*.pyx,*.inc,*.html"
fi
echo -e "No problem detected by flake8\n"
33 changes: 23 additions & 10 deletions docs/src/gensim_theme/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<!-- Google Tag Manager JD-20170830 -->
<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-MP366CC');</script>
<!-- End Google Tag Manager -->

<meta http-equiv="Content-Type" content="text/html; charset={{ encoding }}" />
<meta property="description" content="Efficient topic modelling of text semantics in Python." />
<meta property="og:title" content="gensim: topic modelling for humans" />
Expand All @@ -47,21 +55,26 @@

<link rel="shortcut icon" href="{{ pathto('_static/favicon.ico', 1) }}"/>

<script type="text/javascript">
var _gaq = _gaq || [];
_gaq.push(['_setAccount', 'UA-24066335-1']);
_gaq.push(['_trackPageview']);

(function() {
var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
})();
<script type="text/javascript"> // only commented for the moment - JD-20170830
Copy link
Owner

@piskvorky piskvorky Aug 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to remove code than to comment it out.

The full history is stored, versioned and archived by git anyway, in case we ever need to go back. Like this we only bloat up the pages for no reason (slower page download, harder to read source, more room for error).

// var _gaq = _gaq || [];
// _gaq.push(['_setAccount', 'UA-24066335-1']);
// _gaq.push(['_trackPageview']);
//
// (function() {
// var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
// ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
// var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
// })();
</script>

</head>

<body>
<!-- Google Tag Manager (noscript) JD-20170830-->
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-MP366CC"
height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
<!-- End Google Tag Manager (noscript) -->

<div id="topwrap">
{% block header %}
<div id="top1">
Expand Down