fix: Set framebuffer to null only when canvas source matches main canvas #10966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In my work on @pixi-essentials/svg, I was seeing that copying from a canvas to a render texture was not working using
renderer.renderTarget.copyToTexture
, even though the signature accepts canvas sources. I traced it to PixiJS assigning the canvas texture anull
framebuffer on binding to WebGL. This is because it incorrectly assumes that a canvas input must be the main canvas.https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/bindFramebuffer
Pre-Merge Checklist
npm run lint
)npm run test
)