fix: misjudge certificate expiring (minio#2127)

pjuarezd · May 22, 2024 · 1c2fa4f · 1c2fa4f
1 parent 56c1e35
commit 1c2fa4f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/controller/custom.go b/pkg/controller/custom.go
@@ -112,10 +112,10 @@ func (c *Controller) getCustomCertificates(ctx context.Context, tenant *miniov2.
 				if expiresInDays > 0 && expiresInDays < 10 {
 					c.recorder.Event(tenant, corev1.EventTypeWarning, "CertificateExpiryImminent", fmt.Sprintf("%s certificate '%s' is expiring in %d days", certType, secret.Name, expiresInDays))
 				}
-				if expiresInDays > 0 && expiresInDays < 1 {
+				if expiresIn > 0 && expiresIn < 24*time.Hour {
 					expiresInHuman = fmt.Sprintf("%v hours, %v minutes, and %v seconds", expiresInHours, expiresInMinutes, expiresInSeconds)
 				}
-				if expiresInDays <= 0 {
+				if expiresIn <= 0 {
 					c.recorder.Event(tenant, corev1.EventTypeWarning, "CertificateExpired", fmt.Sprintf("%s certificate '%s' has expired", certType, secret.Name))
 					expiresInHuman = "EXPIRED"
 				}