*7567 Added time zone config setting* #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Starting from PHP 5.3.0 PHP will throw an E_WARNING if the default | ||
| // time zone is not set and date/time functions are used | ||
| // http://pl.php.net/manual/en/function.date-default-timezone-set.php | ||
| if ($timeZone = AppLocale::getTimeZone()) { |
There was a problem hiding this comment.
AppLocale::getTimeZone() should always return a time zone right? So I am not sure this check is needed, unless you want to capture some error (someone changed the getTimeZone() method, for example, and now it can return null), but then you have to assert(false) if the condition you are testing here is false so developers will know the error and where it is. Makes sense?
|
Added requested changes. |
asmecher
added a commit
that referenced
this pull request
Feb 11, 2014
*7567 Added time zone config setting*
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for: http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=7567