Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth search issue #6558

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Depth search issue #6558

merged 3 commits into from
Jan 8, 2025

Conversation

TechSubham
Copy link
Member

Closes #5856

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit d81a6cb
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6771c14555503100080d8dc9

@TechSubham
Copy link
Member Author

I have fixed the bug , i request someone to review the changes i have made

stevepiercy
stevepiercy requested changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started my review, and realized that I already reviewed most of this stuff from your earlier PR. See my suggestion about how to fix this branch. Until you do, no one else should look at this PR.

packages/volto/cypress/downloads/downloads.html Outdated Show resolved Hide resolved
packages/volto/src/icons/save1.svg Outdated Show resolved Hide resolved
packages/volto/src/icons/save2 2.crdownload Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/locales/volto.pot Outdated Show resolved Hide resolved
packages/volto/news/2039.feature Outdated Show resolved Hide resolved
@TechSubham
Copy link
Member Author

I have fixed the errors and i am sorry for the inconvenience caused

stevepiercy
stevepiercy requested changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the change log, I think this is ready for a review from the Volto Team. Thank you for your work!

packages/volto/news/5856.bugfix Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

@mbarde would you please check out this branch and test it to ensure it resolves the issue you reported, and let us know? Thank you!

@TechSubham @stevepiercy
Changelog updated
d81a6cb 
Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy stevepiercy requested a review from a team December 29, 2024 21:41
@sneridagh sneridagh merged commit 6c670da into plone:main Jan 8, 2025
44 checks passed
sneridagh added a commit that referenced this pull request Jan 10, 2025
@sneridagh
Merge branch 'main' into plip6320-Vite-as-Volto-bundler
8330fd9 
* main:
  Slate Italian translations (#6563)
  Release 18.5.0
  Fix robots.txt in devmode (#6571)
  added swedish translation (#6557)
  Depth search issue (#6558)
  Block examples documentation (#6560)
  Fixed folder contents issues with persistent selection (#6554)
  Fix redirects to MDN responsive images (#6552)
  Bugfix remove query string inclusion in body class generation logic (#6547)
  Show related items (#4381)
  Update links to kitconcept.com
  Release 18.4.0
  Release @plone/components 3.0.1
  Release @plone/types 1.2.0
  Fix precedence of the quanta layer by adding a base layer for all the… (#6539)
  Add monorepo structure to the README (#6542)
sneridagh added a commit that referenced this pull request Jan 21, 2025
@sneridagh
Merge branch 'main' into robots-txt-setting
ad3d9e1 
* main: (741 commits)
  Improve the usability of the ObjectBrowser when inputting a manual value, checking it on blur, and adding a local validator (#6576)
  fixing Markdown heading (#6588)
  fix site logo issue (#6591)
  Route registry (#6600)
  Release @plone/client 1.0.0-alpha.21
  Export the getContent bare fetcher (#6594)
  fix: incorrect copied state useClipboard (#6585)
  [RR7] Update to latest RR7 and conventions, fix index page (#6589)
  Release 18.6.0
  Release @plone/slate 18.1.0
  Revert "added swedish translation" (#6578)
  Slate Italian translations (#6563)
  Release 18.5.0
  Fix robots.txt in devmode (#6571)
  added swedish translation (#6557)
  Depth search issue (#6558)
  Block examples documentation (#6560)
  Fixed folder contents issues with persistent selection (#6554)
  Fix redirects to MDN responsive images (#6552)
  Bugfix remove query string inclusion in body class generation logic (#6547)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuliaghisini giuliaghisini giuliaghisini approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

Assignees
No one assigned
Labels
24 status: ready 32 needs: review First Contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search block ignores depth setting
4 participants
@TechSubham @stevepiercy @giuliaghisini @sneridagh