Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix site logo issue #6591

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Conversation

Shyam-Raghuwanshi
Copy link
Contributor

@Shyam-Raghuwanshi Shyam-Raghuwanshi commented Jan 14, 2025


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit bcd087f
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/678acc74e797d50008d20ba4

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't solve the HTTP caching issues in #6579, so please remove "Closes #6579" from the PR description. But it does look like a helpful fix for how the component state is managed. Please add a change log entry (https://6.docs.plone.org/contributing/index.html#change-log-entry) to make it ready for final review.

packages/volto/news/6591.fix Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request description should include Ref #6579. GitHub will not close the issue when this referenced PR is merged with that syntax because Ref is not a GitHub keyword, but it will at least have a link to it in a prominent location. From Create a pull request from your fork, Item 2:

See also
Linking a pull request to an issue using a keyword

See also Autolinked references and URLs for non-keyword auto-linking references.

packages/volto/news/6591.feature Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News LGTM. Needs another technical review.

@stevepiercy stevepiercy requested a review from a team January 17, 2025 22:16
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davisagli davisagli merged commit ae58c67 into plone:main Jan 17, 2025
44 checks passed
@Shyam-Raghuwanshi Shyam-Raghuwanshi deleted the fixing-site-logo branch January 18, 2025 05:32
sneridagh added a commit that referenced this pull request Jan 21, 2025
* main: (741 commits)
  Improve the usability of the ObjectBrowser when inputting a manual value, checking it on blur, and adding a local validator (#6576)
  fixing Markdown heading (#6588)
  fix site logo issue (#6591)
  Route registry (#6600)
  Release @plone/client 1.0.0-alpha.21
  Export the getContent bare fetcher (#6594)
  fix: incorrect copied state useClipboard (#6585)
  [RR7] Update to latest RR7 and conventions, fix index page (#6589)
  Release 18.6.0
  Release @plone/slate 18.1.0
  Revert "added swedish translation" (#6578)
  Slate Italian translations (#6563)
  Release 18.5.0
  Fix robots.txt in devmode (#6571)
  added swedish translation (#6557)
  Depth search issue (#6558)
  Block examples documentation (#6560)
  Fixed folder contents issues with persistent selection (#6554)
  Fix redirects to MDN responsive images (#6552)
  Bugfix remove query string inclusion in body class generation logic (#6547)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants