-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix site logo issue #6591
fix site logo issue #6591
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't solve the HTTP caching issues in #6579, so please remove "Closes #6579" from the PR description. But it does look like a helpful fix for how the component state is managed. Please add a change log entry (https://6.docs.plone.org/contributing/index.html#change-log-entry) to make it ready for final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pull request description should include Ref #6579
. GitHub will not close the issue when this referenced PR is merged with that syntax because Ref
is not a GitHub keyword, but it will at least have a link to it in a prominent location. From Create a pull request from your fork, Item 2:
See also Autolinked references and URLs for non-keyword auto-linking references.
packages/volto/src/components/manage/Widgets/RegistryImageWidget.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Piercy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News LGTM. Needs another technical review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* main: (741 commits) Improve the usability of the ObjectBrowser when inputting a manual value, checking it on blur, and adding a local validator (#6576) fixing Markdown heading (#6588) fix site logo issue (#6591) Route registry (#6600) Release @plone/client 1.0.0-alpha.21 Export the getContent bare fetcher (#6594) fix: incorrect copied state useClipboard (#6585) [RR7] Update to latest RR7 and conventions, fix index page (#6589) Release 18.6.0 Release @plone/slate 18.1.0 Revert "added swedish translation" (#6578) Slate Italian translations (#6563) Release 18.5.0 Fix robots.txt in devmode (#6571) added swedish translation (#6557) Depth search issue (#6558) Block examples documentation (#6560) Fixed folder contents issues with persistent selection (#6554) Fix redirects to MDN responsive images (#6552) Bugfix remove query string inclusion in body class generation logic (#6547) ...
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.