Fix target and referer reporting when PHP and database differ on timezone #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the date. My hosting has strftime in UTC and DATE(NOW()) in Amsterdam's time. This broke top referer and top target reporting when only reporting today's top, for 1 or 2 hours per day, depending on daylight savings time. I replaced all occurences of DATE(NOW()) in queries with calls to strftime.
The result is equivalent with neglectable performance difference. To not create any confusion by use of the "timestamp" which does not return a UTC timestamp, as probably expected, but one with zone offset, we now simply pass the format argument to current_time().
bueltge
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hosting provider has strftime in UTC and DATE(NOW()) in Amsterdam time.
This broke top referer and top target reporting when reporting today's
top, for 1 or 2 hours per day, depending on daylight savings time.