Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Makefile checkers when starting localnet #466

Merged
merged 10 commits into from
Apr 11, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Apr 8, 2024

Summary

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

@Olshansk Olshansk added the tooling Tooling - CLI, scripts, helpers, off-chain, etc... label Apr 8, 2024
@Olshansk Olshansk added this to the Shannon Quality of Life milestone Apr 8, 2024
@Olshansk Olshansk requested review from red-0ne and okdas April 8, 2024 20:53
@Olshansk Olshansk self-assigned this Apr 8, 2024
Copy link

github-actions bot commented Apr 9, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Apr 9, 2024
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT changes and preemptively approving 👍

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. We didn't have that to allow other k8s distributions, but I'm happy if we force devs to use kind only :)

@Olshansk Olshansk merged commit b229728 into main Apr 11, 2024
9 checks passed
bryanchriswhite added a commit that referenced this pull request Apr 12, 2024
…ment

* pokt/main:
  Update test instructions pull_request_template.md (#473)
  [Tooling] Makefile checkers when starting localnet (#466)
  [LocalNet] Switch validator logs to json (#480)
bryanchriswhite added a commit that referenced this pull request Apr 17, 2024
* pokt/main:
  [TODOs] Add todos for future smt optimizations (#423)
  [Metrics] feat: Initial on-chain metrics implementation (#449)
  [Tooling] Add application stake/unstake/delegate logs (#482)
  [SMT] Updated smt release from v0.9.2 -> v0.10.2 (#472)
  [Docs] update supplier actor CLI section (#471)
  [Testing] chore: add make targets & update feature path logging (#470)
  [Metrics] Additional off-chain metrics (#468)
  Update test instructions pull_request_template.md (#473)
  [Tooling] Makefile checkers when starting localnet (#466)
  [LocalNet] Switch validator logs to json (#480)
  [Documentation] Refactor poktroll documentation so its easier to navigate (#474)
  [LocalNet] Add observability stack (#475)
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
@Olshansk Olshansk deleted the localnet_makefile_checks branch May 29, 2024 16:44
okdas added a commit that referenced this pull request Nov 14, 2024
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Dima Kniazev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants