[LocalNet] Switch validator logs to json #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdas
added
infra
|
@Olshansk I'm going to merge this but lmk if you'd like to change anything. |
Olshansk
pushed a commit
that referenced
this pull request
Apr 11, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Apr 17, 2024
* pokt/main: [TODOs] Add todos for future smt optimizations (#423) [Metrics] feat: Initial on-chain metrics implementation (#449) [Tooling] Add application stake/unstake/delegate logs (#482) [SMT] Updated smt release from v0.9.2 -> v0.10.2 (#472) [Docs] update supplier actor CLI section (#471) [Testing] chore: add make targets & update feature path logging (#470) [Metrics] Additional off-chain metrics (#468) Update test instructions pull_request_template.md (#473) [Tooling] Makefile checkers when starting localnet (#466) [LocalNet] Switch validator logs to json (#480) [Documentation] Refactor poktroll documentation so its easier to navigate (#474) [LocalNet] Add observability stack (#475)
okdas
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JSON logs are easier to run queries against. Let's switch to json by default (just like appgate-server and relayminer) but allow modifying the log format and log level via
localnet_config.yamlRelated helm chart feature: https://github.com/pokt-network/helm-charts/pull/33/files
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.make docusaurus_startSanity Checklist