[Bug] Fix pprof endpoint #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
reviewed
Apr 26, 2024
pkg/appgateserver/server.go
Outdated
| go func() { | ||
| <-ctx.Done() | ||
| app.logger.Info().Str("endpoint", addr).Msg("stopping a pprof endpoint") | ||
| server.Close() |
There was a problem hiding this comment.
What about using server.Shutdown(ctx) which does graceful shut down?
I would also have the same pattern for metrics server, instead of relying on tcp.Listener
server := &http.Server{
Addr: addr,
Handler: pprofMux,
}
...
server.ListenAndServe()
...
server.Shutdown(ctx)
There was a problem hiding this comment.
I'll do this! I wasn't sure which one to use. I guess I should've asked gpt first.
red-0ne
approved these changes
Apr 26, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Apr 29, 2024
…cept * pokt/main: [Dashboard] Supplier logs dashboard (#502) [Utility] Update SessionSettlement when app goes into a negative amount (#509) [Testing] Supplier staking E2E test (#498) [RelayMiner] Support https backend urls (#507) [Bug] Fix pprof endpoint (#505) [LocalNet] Remove tilt-restart-wrapper (#504) [LocalNet][Hotfix] Turn off pproff by default (#500) [Tooling] Add pprof endpoints and documentation (#484) [Documentation] Basic blockchain operations (#454) [BlockClient] Refactor BlockClient to fetch latest block at init (#444)
okdas
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pprof prevents services from starting. It was not run inside a routine and caused a lock where it shouldn't have been.
Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist